[CMake] Correctly set library prefix on Windows #19666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
added
in:Build System
clean build
Test Results 21 files 21 suites 3d 10h 42m 34s ⏱️ For more details on these failures, see this check. Results for commit 95b25d9. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
issue-15792
branch
3 times, most recently
from
48afb79 to
83590f0
Compare
pcanal
reviewed
Aug 18, 2025
guitargeek
force-pushed
the
issue-15792
branch
from
83590f0 to
ef6394c
Compare
guitargeek
changed the title
MODULE target also for dictionary name
Contributor
Author
|
Hi @pcanal, thanks for taking a look! There were too many moving parts. Now I intend to first get some sane suffix and prefix settings also on Windows and continue from there. |
pcanal
reviewed
Aug 18, 2025
guitargeek
force-pushed
the
issue-15792
branch
2 times, most recently
from
5d4678f to
6e46d42
Compare
Instead of adding the prefix to the output name, it should be set separately.
guitargeek
force-pushed
the
issue-15792
branch
2 times, most recently
from
f492f75 to
95b25d9
Compare
Contributor
Author
|
I think I got it now: |
Member
Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of adding the prefix to the output name, it should be set
separately.